-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api.Client: support isolated read-after-write #12814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Oct 13, 2021
768ead6
to
8a6dc86
Compare
ncabatoff
reviewed
Oct 13, 2021
ncabatoff
reviewed
Oct 13, 2021
ncabatoff
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve because the only thing still being worked out is the name for the config option, and I'm happy to go with whatever Brian and Ben agree on.
- rebase off of main
- The SharedReplicationStateStore provides cluster replication state storage that is easily integrated in the Client's response/request callback chains.
- no longer rely in response/request callbacks for updating the replication state store - make setting up the store simpler by adding a configuration directive - address other comments. - revert go version changes go.mod
- replace the use of channels with a WaitGroup
- replace doc references to stale reads with read-after-write
48fbd3f
to
d8c472e
Compare
vinay-gopalan
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for a Client to track all cluster replication states. The new
ReplicationStateStore
providesresponse
andrequest
callback methods to the Client, and can be used across Client clones.Related PR: hashicorp/terraform-provider-vault#1188