auth/cert: Add certificate extensions as metadata #13348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterverraedt
force-pushed
the
certs-metadata
branch
from
4280b8a to
47fabd6
Compare
peterverraedt
force-pushed
the
certs-metadata
branch
from
bde5e18 to
664e587
Compare
peterverraedt
force-pushed
the
certs-metadata
branch
from
664e587 to
6befca2
Compare
|
Hey @peterverraedt ! Sorry for the delay here, I've been caught up with other stuff but I'll be sure to review this PR this week, and thanks for the prompt response to the feedback we gave! |
pmmukh
reviewed
Dec 23, 2021
peterverraedt
force-pushed
the
certs-metadata
branch
from
6befca2 to
4c12277
Compare
pmmukh
approved these changes
Jan 3, 2022
|
Also, could you please rebase this branch off main ? There's some test failures that should be fixed in main now. |
peterverraedt
force-pushed
the
certs-metadata
branch
from
4c12277 to
0b5a1c9
Compare
Signed-off-by: Peter Verraedt <[email protected]>
Signed-off-by: Peter Verraedt <[email protected]>
peterverraedt
force-pushed
the
certs-metadata
branch
from
0b5a1c9 to
03f3a86
Compare
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* auth/cert: Add certificate extensions as metadata Signed-off-by: Peter Verraedt <[email protected]> * Add changelog for hashicorp#13348 Signed-off-by: Peter Verraedt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds certificate extensions as metadata to be used in vault policy templates. We parse the ASN1 objectidentifiers to a string separated by dashes instead of dots, to ease the use in golang templating language.
Fixes: #13347
Refs: #10503
Signed-off-by: Peter Verraedt [email protected]