-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo: Corrected same typo in 2 locations (on-premise to on-premises) #13402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr48
changed the title
TYPO: Corrected same typo in 2 locations (on-premise to on-premises)
Typo: Corrected same typo in 2 locations (on-premise to on-premises)
Dec 11, 2021
hghaf099
reviewed
Feb 4, 2022
Would you please also resolve the conflict. |
I merged main into my branch and resolved conflict. One of the files I modified was deleted, so that change no longer appears. Thanks. |
hghaf099
reviewed
Feb 7, 2022
cr48
commented
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
hghaf099
approved these changes
Feb 7, 2022
fairclothjm
pushed a commit
that referenced
this pull request
Feb 12, 2022
…13402) * Fixed 2 typos on-premise to on-premises. * Added changelog file. * Removed 13402.txt file from changelog. * Update website/content/docs/secrets/terraform.mdx Co-authored-by: hghaf099 <[email protected]>
yhyakuna
pushed a commit
that referenced
this pull request
Aug 19, 2022
…13402) * Fixed 2 typos on-premise to on-premises. * Added changelog file. * Removed 13402.txt file from changelog. * Update website/content/docs/secrets/terraform.mdx Co-authored-by: hghaf099 <[email protected]>
yhyakuna
added a commit
that referenced
this pull request
Aug 22, 2022
…13402) (#16802) * Fixed 2 typos on-premise to on-premises. * Added changelog file. * Removed 13402.txt file from changelog. * Update website/content/docs/secrets/terraform.mdx Co-authored-by: hghaf099 <[email protected]> Co-authored-by: cr48 <[email protected]> Co-authored-by: hghaf099 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what it accomplishes: "on-premise" should be "on-premises", since "premise" has a different meaning
how it does so: modified 2 files in the website folder