Reading consul access configuration in the consul secret backend. #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return &b | ||
| } | ||
|
|
||
| func TestBackend_config_access(t *testing.T) { |
There was a problem hiding this comment.
This needs the guard for acceptance testing, as otherwise all runs will fail if consul isn't available (like on Travis).
There was a problem hiding this comment.
Yep. Had noticed that. Pushed the change. Thanks for pointing it out!
vishalnayak
force-pushed
the
consul-fixups
branch
from
bfe1004 to
1b7662b
Compare
vishalnayak
force-pushed
the
consul-fixups
branch
from
1b7662b to
d6d5dac
Compare
swayne275
added a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tokenwill not be sent in the response.