Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the OpenAPI reference objects change #14217 #14506

Closed
wants to merge 2 commits into from

Conversation

averche
Copy link
Contributor

@averche averche commented Mar 15, 2022

The change in the structure of OpenAPI spec to add reference objects (#14217) caused portions of the UI to break. Reverting this change for now while we investigate & fix the issue.

@vercel vercel bot temporarily deployed to Preview – vault-storybook March 15, 2022 18:55 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 15, 2022 18:55 Inactive
@averche averche requested review from VinnyHC, a team and hashishaw March 15, 2022 19:23
Copy link
Contributor

@VinnyHC VinnyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, not sure what the official "revert" process is WRT changelog and such.

@averche
Copy link
Contributor Author

averche commented Mar 15, 2022

The UI issue has been fixed in #14508, closing this PR

@averche averche closed this Mar 15, 2022
@averche averche deleted the averche/revert-openapi-change branch March 28, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants