OIDC Logout Bug #14545
Merged
OIDC Logout Bug #14545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
approved these changes
Mar 17, 2022
ui/app/components/auth-form.js
Outdated
| @@ -206,12 +211,15 @@ export default Component.extend(DEFAULTS, { | |||
| showLoading: or('isLoading', 'authenticate.isRunning', 'fetchMethods.isRunning', 'unwrapToken.isRunning'), | |||
|
|
|||
| authenticate: task( | |||
| waitFor(function* (backendType, data) { | |||
| let clusterId = this.cluster.id; | |||
| waitFor(function* (backend, data) { | |||
There was a problem hiding this comment.
I do like that the previous name was clear that this is the backend type, not the backend name. Could we add a comment or keep the old name here?
There was a problem hiding this comment.
Sure I can change it back. The auth service authenticate method has it named backend so I thought I would align it that way.
This was referenced Mar 18, 2022
zofskeez
added a commit
that referenced
this pull request
Mar 18, 2022
* fixes issue with token auth selected after logging out from oidc or jwt methods * adds changelog entry * reverts backendType var name change in auth-form authenticate method
zofskeez
added a commit
that referenced
this pull request
Mar 18, 2022
* fixes issue with token auth selected after logging out from oidc or jwt methods * adds changelog entry * reverts backendType var name change in auth-form authenticate method
zofskeez
added a commit
that referenced
this pull request
Mar 18, 2022
zofskeez
added a commit
that referenced
this pull request
Mar 18, 2022
This was referenced Mar 18, 2022
This was referenced Mar 21, 2022
This was referenced Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that when logging out when previously authenticated via OIDC or JWT auth methods the
withquery param is set totokenwhich hydrates the auth form with thetokenauth method selected rather than the previously logged in method. To ensure that the selected auth method persists I updated the auth service to usesessionStoragefor this piece of state.