Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-test-selectors #14937

Merged
merged 10 commits into from
Apr 6, 2022
Prev Previous commit
Next Next commit
fixes remaining test selector issues
  • Loading branch information
zofskeez committed Apr 6, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d1176ef91b1f78007c2d7372e040dbb080ddde29
2 changes: 1 addition & 1 deletion ui/app/components/b64-toggle.js
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ const B64 = 'base64';
const UTF8 = 'utf-8';
export default Component.extend({
tagName: 'button',
attributeBindings: ['type'],
attributeBindings: ['type', 'data-test-transit-b64-toggle'],
type: 'button',
classNames: ['button', 'b64-toggle'],
classNameBindings: ['isInput:is-input:is-textarea'],
2 changes: 1 addition & 1 deletion ui/app/templates/components/secret-create-or-update.hbs
Original file line number Diff line number Diff line change
@@ -115,7 +115,7 @@
@isOpen={{this.showMetadata}}
@openLabel="Hide secret metadata"
@closedLabel="Show secret metadata"
@onClick={{fn (mut this.showData)}}
@onClick={{fn (mut this.showMetadata)}}
class="is-block"
data-test-show-metadata-toggle
/>
2 changes: 1 addition & 1 deletion ui/app/templates/components/tool-hash.hbs
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@
</label>
<div class="control">
<Textarea id="input-hash" name="input" @value={{@input}} class="textarea" data-test-tools-input="hash-input" />
<B64Toggle @value={{@input}} @isInput={{false}} @data-test-tools-b64-toggle="input" />
<B64Toggle @value={{@input}} @isInput={{false}} @data-test-transit-b64-toggle="input" />
</div>
</div>
<div class="field is-horizontal">
1 change: 0 additions & 1 deletion ui/app/templates/vault/cluster/secrets/backend/list.hbs
Original file line number Diff line number Diff line change
@@ -50,7 +50,6 @@
@shouldNavigateTree={{options.navigateTree}}
@placeholder={{options.searchPlaceholder}}
@mode={{if (eq this.tab "certs") "secrets-cert" "secrets"}}
@data-test-nav-input={{true}}
/>
{{#if this.filterFocused}}
{{#if this.filterMatchesKey}}
2 changes: 1 addition & 1 deletion ui/lib/core/addon/components/string-list.js
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ import layout from '../templates/components/string-list';
export default Component.extend({
layout,
'data-test-component': 'string-list',
attributeBindings: ['data-test-component'],
attributeBindings: ['data-test-component', 'data-test-input'],
classNames: ['field', 'string-list', 'form-section'],

/*
2 changes: 1 addition & 1 deletion ui/lib/core/addon/templates/components/navigate-input.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="field">
<div class="field" data-test-nav-input>
<p class="control has-icons-left">
<input
class="filter input"
2 changes: 1 addition & 1 deletion ui/tests/acceptance/tools-test.js
Original file line number Diff line number Diff line change
@@ -107,7 +107,7 @@ module('Acceptance | tools', function (hooks) {
await click('[data-test-tools-action-link="hash"]');

await fillIn('[data-test-tools-input="hash-input"]', 'foo');
await click('[data-test-tools-b64-toggle="input"]');
await click('[data-test-transit-b64-toggle="input"]');

await click('[data-test-tools-submit]');
let sumInput = await waitUntil(() => find('[data-test-tools-input="sum"]'));