Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OIDC callback query params #15378

Merged
merged 5 commits into from
May 13, 2022
Merged

Fix OIDC callback query params #15378

merged 5 commits into from
May 13, 2022

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented May 11, 2022

  • Value of namespace was getting stripped from the state query param
  • Used native URL search param api to fetch the values

@arnav28 arnav28 added the ui label May 11, 2022
@arnav28 arnav28 requested a review from austingebauer as a code owner May 11, 2022 20:50
zofskeez
zofskeez reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall! I left a comment with a suggestion to simplify things for your review.

ui/app/routes/vault/cluster/oidc-callback.js Outdated Show resolved Hide resolved
arnav28 added 3 commits May 12, 2022 10:47
@arnav28
Fix OIDC callback query params
3b3b646 
- Value of namespace was getting stripped from the state query param
- Used native URL search param api to fetch the values
@arnav28
Add changelog
ddbe120
@arnav28
Remove unnecessary check for url encoding
8d1fe4d
@arnav28 arnav28 force-pushed the ui/oidc-callback-bug branch from 8a4d859 to 8d1fe4d Compare May 12, 2022 17:50
zofskeez
zofskeez approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hashishaw
hashishaw approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for the update!

hashishaw
hashishaw reviewed May 13, 2022
View reviewed changes
changelog/15378.txt Outdated Show resolved Hide resolved
@arnav28 arnav28 merged commit 74b1eec into main May 13, 2022
@arnav28 arnav28 deleted the ui/oidc-callback-bug branch May 13, 2022 16:59
This was referenced May 13, 2022
Merged
Merged
@Monkeychip Monkeychip mentioned this pull request Mar 6, 2023
Merged
This was referenced Mar 23, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

@zofskeez zofskeez zofskeez approved these changes

@austingebauer austingebauer Awaiting requested review from austingebauer

@hellobontempo hellobontempo Awaiting requested review from hellobontempo

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnav28 @zofskeez @hashishaw