VAULT-4306 Ensure /raft/bootstrap/challenge call ignores erroneous namespaces set #15519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swayne275
approved these changes
May 19, 2022
ncabatoff
reviewed
May 19, 2022
Co-authored-by: Nick Cabatoff <[email protected]>
ncabatoff
approved these changes
May 19, 2022
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
…mespaces set (hashicorp#15519) * VAULT-4306 Ensure /raft/bootstrap/challenge call ignores erroneous namespaces set * VAULT-4306 Add changelog * VAULT-4306 Update changelog/15519.txt Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures servers started on an environment where $VAULT_NAMESPACE is set do not use such a variable when making this kind of call, causing an error.
Notably, this file seems to be the only place where stripping the namespace makes sense (other API clients come from a CLI/api client call, where the namespace makes sense), which is why I did not make it a configuration item for ApiClient or similar. If it becomes a more general need, it makes sense to make the configuration change then, but it didn't make sense to me to add a new configuration item or method for what appears to be a snowflake.