HTTP Server should handle standby redirects #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,8 +63,12 @@ func parseRequest(r *http.Request, out interface{}) error { | |||
|
|
|||
| // request is a helper to perform a request and properly exit in the | |||
| // case of an error. | |||
| func request(core *vault.Core, w http.ResponseWriter, r *logical.Request) (*logical.Response, bool) { | |||
| func request(core *vault.Core, w http.ResponseWriter, reqURL *url.URL, r *logical.Request) (*logical.Response, bool) { | |||
There was a problem hiding this comment.
instead of doing url.URL lets just pass the full http.Request object through. We don't know when we might need it in the future and it actually makes it easier to call as a client: w, r is pretty esa.
|
One comment but LGTM,good catch. |
|
@mitchellh Good call. Updated. |
armon
added a commit
that referenced
this pull request
Apr 19, 2015
HTTP Server should handle standby redirects
|
@mitchellh I started the client redirect but ran into some issues. The main one is that the io.Reader gets consumed in the original request. Thoughts? |
|
@armon Hm, if it doesn't work, we can always make a special response type that we catch at the API layer and re-send it. |
jeffwecan
added a commit
to jeffwecan/vault
that referenced
this pull request
Nov 7, 2018
…e_subnets [SRE-2000] Handle Multiple Subnets In VPC Peering Module
briankassouf
pushed a commit
that referenced
this pull request
Aug 24, 2020
Bring over PSIRT-37 changes from ENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the HTTP server to generate 307 redirects when in standby mode. 307 is used instead of 302 because 302 causes the HTTP METHOD to switch to GET regardless of the original method.
Outstanding issues:
/cc: @mitchellh