Remove gox in favor of go build. #16353

swenson · 2022-07-19T18:09:12Z

gox hasn't had a release to update it in many years, so is missing
support for many modern systems, like darwin/arm64.

In any case, we only use it for dev builds, where we don't even use
the ability of it to build for multiple platforms. Release builds use
go build now.

So, this switches to go build everywhere.

I pulled this down and tested it in Windows as well. (Side note: I
couldn't get gox to work in Windows, so couldn't build before this
change.)

swenson · 2022-07-19T18:14:26Z

scripts/docker/Dockerfile

@@ -1,6 +1,5 @@
 # Multi-stage builder to avoid polluting users environment with wrong
-# architecture binaries.  Since this binary is used in an alpine container,
-# we're explicitly compiling for 'linux/amd64'
+# architecture binaries.


I removed this comment about linux/amd64 as I was able to successfully get this to work on linux/arm64 on my Mac as well (but not Dockerfile.ui due to problems with the debian distro).

mpalmi · 2022-07-19T18:53:52Z

This looks good to me. Nothing really jumped out at me and I was able to build locally (darwin/arm64).

Just in case you missed this reference, should we update the website content to remove the gox recommendation for building plugins?

➜  vault (5c61957f39) rg "gox" website/
website/content/docs/secrets/databases/custom.mdx
211:build with [gox](https://github.com/mitchellh/gox) for cross platform builds.

swenson · 2022-07-19T19:02:24Z

Ah, thanks, I had missed that reference in the docs. Will remove.

tomhjp

LGTM

benashz

LGTM!

ncabatoff · 2022-07-20T13:40:45Z

scripts/build.sh

-    -tags="${BUILD_TAGS}" \
-    -gocmd="${GO_CMD}" \
+    -ldflags "${LD_FLAGS} -X github.com/hashicorp/vault/sdk/version.GitCommit='${GIT_COMMIT}${GIT_DIRTY}' -X github.com/hashicorp/vault/sdk/version.BuildDate=${BUILD_DATE}" \
+    -o "bin/vault" \


This bit will probably be missed:

rm -f ${MAIN_GOPATH}/bin/vault cp ${F} ${MAIN_GOPATH}/bin/

Can you do something equivalent? People are used to the newly built being in their path.
Also the rm is important on macos, something to do with their binary scanning/validation.

go build does this under the hood already: golang/go@cf7aa58 (thanks to mitchellh for the link).

I'll re-add the bit to copy into the GOPATH.

It does that for the build target, but if we're copying into GOPATH, that binary will still be vulnerable to the same problem, I think. Happy to test it once you've made the change if you like.

I kept the rm for the copy into GOPATH. It should be committed now if you would like to test.

Yeah, I just tested with a manual cp, and it gets sigkilled.

Tested your branch, works!

ncabatoff · 2022-07-20T13:46:53Z

website/content/docs/secrets/databases/custom.mdx

@@ -207,8 +207,7 @@ func Run() error {
 ## Running your plugin

 The above main package, once built, will supply you with a binary of your
-plugin. We also recommend if you are planning on distributing your plugin to
-build with [gox](https://github.com/mitchellh/gox) for cross platform builds.
+plugin.


Might not include this bit, our removal of gox from vault doesn't necessarily have implications for plugins.

ncabatoff · 2022-07-20T13:49:11Z

Looks good modulo my comments above. When this is merged, please email team-vault to inform them of this change. The only user-facing impact I see is that those who are used to using XC_OSARCH for cross platform builds will now want to use GOOS/GOARCH instead, but if you've noticed anything else you could mention that too.

`gox` hasn't had a release to update it in many years, so is missing support for many modern systems, like `darwin/arm64`. In any case, we only use it for dev builds, where we don't even use the ability of it to build for multiple platforms. Release builds use `go build` now. So, this switches to `go build` everywhere. I pulled this down and tested it in Windows as well. (Side note: I couldn't get `gox` to work in Windows, so couldn't build before this change.)

swenson · 2022-07-20T17:21:03Z

Thanks everyone!

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

gox is no longer maintained and releases are done with now. See hashicorp/vault#16353 where we removed gox in Vault.

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

gox is no longer maintained and releases are done with now. See hashicorp/vault#16353 where we removed gox in Vault.

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

* Remove gox in favor of go build gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault. * revert accidental commit of snowflake.go file * update readme link * re-revert snowflake.go; confusion bc branch needed rebase

swenson requested review from mladlow and a team July 19, 2022 18:09

swenson force-pushed the remove-gox branch from fe45af7 to 5c61957 Compare July 19, 2022 18:11

swenson commented Jul 19, 2022

View reviewed changes

swenson requested a review from taoism4504 as a code owner July 19, 2022 19:02

vercel bot deployed to Preview July 19, 2022 19:06 View deployment

tomhjp approved these changes Jul 20, 2022

View reviewed changes

benashz approved these changes Jul 20, 2022

View reviewed changes

ncabatoff reviewed Jul 20, 2022

View reviewed changes

Christopher Swenson added 3 commits July 20, 2022 10:16

Add changleog

c79f661

Copy vault into the GOPATH again

5b406f2

swenson force-pushed the remove-gox branch from 0b41153 to 5b406f2 Compare July 20, 2022 17:17

ncabatoff approved these changes Jul 20, 2022

View reviewed changes

swenson merged commit fa91af9 into main Jul 20, 2022

swenson deleted the remove-gox branch July 20, 2022 17:44

fairclothjm mentioned this pull request Oct 31, 2022

Dependency upgrades hashicorp/vault-plugin-secrets-gcp#152

Merged

fairclothjm mentioned this pull request Jan 24, 2023

Remove gox in favor of go build hashicorp/vault-plugin-auth-alicloud#50

Merged

fairclothjm added a commit to hashicorp/vault-plugin-database-snowflake that referenced this pull request Mar 16, 2023

Remove gox in favor of go build

7bd1a89

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

fairclothjm mentioned this pull request Mar 16, 2023

Remove gox in favor of go build hashicorp/vault-plugin-database-snowflake#26

Merged

fairclothjm added a commit to hashicorp/vault-plugin-secrets-ad that referenced this pull request Mar 16, 2023

Remove gox in favor of go build

09abbfa

gox is no longer maintained and releases are done with now. See hashicorp/vault#16353 where we removed gox in Vault.

fairclothjm mentioned this pull request Mar 16, 2023

Remove gox in favor of go build hashicorp/vault-plugin-secrets-ad#102

Merged

fairclothjm added a commit to hashicorp/vault-plugin-secrets-terraform that referenced this pull request Mar 16, 2023

Remove gox in favor of go build

6988085

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

fairclothjm mentioned this pull request Mar 16, 2023

Remove gox in favor of go build hashicorp/vault-plugin-secrets-terraform#22

Merged

fairclothjm added a commit to hashicorp/vault-plugin-database-snowflake that referenced this pull request Mar 16, 2023

Remove gox in favor of go build

49bffc0

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

fairclothjm added a commit to hashicorp/vault-plugin-secrets-ad that referenced this pull request Mar 16, 2023

Remove gox in favor of go build (#102)

e0ccab3

gox is no longer maintained and releases are done with now. See hashicorp/vault#16353 where we removed gox in Vault.

fairclothjm added a commit to hashicorp/vault-plugin-secrets-terraform that referenced this pull request Mar 16, 2023

Remove gox in favor of go build (#22)

cb5b48c

gox is no longer maintained and releases are done with `go build` now. See hashicorp/vault#16353 where we removed gox in Vault.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove gox in favor of go build. #16353

Remove gox in favor of go build. #16353

swenson commented Jul 19, 2022

swenson Jul 19, 2022

mpalmi commented Jul 19, 2022

swenson commented Jul 19, 2022

tomhjp left a comment

benashz left a comment

ncabatoff Jul 20, 2022

swenson Jul 20, 2022

ncabatoff Jul 20, 2022

swenson Jul 20, 2022

ncabatoff Jul 20, 2022

ncabatoff Jul 20, 2022

ncabatoff Jul 20, 2022

swenson Jul 20, 2022

ncabatoff commented Jul 20, 2022

swenson commented Jul 20, 2022

Remove gox in favor of go build. #16353

Remove gox in favor of go build. #16353

Conversation

swenson commented Jul 19, 2022

Choose a reason for hiding this comment

mpalmi commented Jul 19, 2022

swenson commented Jul 19, 2022

tomhjp left a comment

Choose a reason for hiding this comment

benashz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncabatoff commented Jul 20, 2022

swenson commented Jul 20, 2022