Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity/oidc: adds detailed listing capability for clients and providers #16567

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

austingebauer
Copy link
Contributor

@austingebauer austingebauer commented Aug 3, 2022

This PR adds detailed listing capability for OIDC clients and providers by introducing the detailed query parameter. The motivation for this is to improve the user experience in the Vault UI.

Example of detailed client list:

$ vault list -detailed identity/oidc/client

Keys      access_token_ttl    assignments    client_id                           client_type     id_token_ttl    key        redirect_uris
----      ----------------    -----------    ---------                           -----------     ------------    ---        -------------
my-app    24h                 [allow_all]    wGr981oYLJbcr4zrUriYxjxSc80JL7HW    confidential    24h             default    [http://localhost:5555/callback]

Example of detailed provider list:

$ vault list -detailed identity/oidc/provider

Keys       allowed_client_ids    issuer                                                     scopes_supported
----       ------------------    ------                                                     ----------------
default    [*]                   http://127.0.0.1:8200/v1/identity/oidc/provider/default    []

@austingebauer austingebauer added this to the 1.12.0-rc1 milestone Aug 3, 2022
@austingebauer austingebauer requested a review from a team August 3, 2022 21:40
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like we're missing a changelog?

@calvn
Copy link
Contributor

calvn commented Aug 3, 2022

Does it support the vault list ... subcommand, and if so what does the output look like?

@austingebauer
Copy link
Contributor Author

austingebauer commented Aug 3, 2022

@calvn - Good question, I thought it might be okay for this to not work with the vault list command, but I'm now seeing ListResponseWithInfo. I think using ListResponseWithInfo is a better option, so I'll go with that. That'll remove the need for the query parameter and allow users to execute vault list ... and vault list -detailed ....

@austingebauer
Copy link
Contributor Author

austingebauer commented Aug 3, 2022

The CLI formats the list with -detailed into a table. I like this better. Changing the approach here.

$ vault list identity/oidc/provider
Keys
----
default

$ vault list -detailed identity/oidc/provider

Keys       allowed_client_ids    issuer                                                     scopes_supported
----       ------------------    ------                                                     ----------------
default    [*]                   http://127.0.0.1:8200/v1/identity/oidc/provider/default    []

@austingebauer
Copy link
Contributor Author

Changed approach to use ListResponseWithInfo in 763b0f3.

@austingebauer austingebauer merged commit 100d7d9 into main Aug 4, 2022
@austingebauer austingebauer deleted the jira-7220-list-detailed branch August 4, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants