Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of VAULT-7698 Fix ignored parameter warnings for endpoint arbitrary data options into release/1.11.x #16868

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16794 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

The below text is copied from the body of the original PR.


The changes made to TestHTTP_Wrapping made the test fail before my fix, and this fixes the issue.

The output of an unwrap no longer contains a warning:

vault write -force sys/wrapping/unwrap
Key    Value
---    -----
foo    bar

I could not find any other endpoint that would be appropriate to add TakesArbitraryInput: true to, but it made sense to me to add the new option to the framework instead of simply making an exception for this particular endpoint, which felt messy. It seems likely we'll have need for this boolean in the future.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/violethynes/VAULT-7698/uniformly-present-beetle branch from 7129c63 to 5d4b6d6 Compare August 24, 2022 14:56
@VioletHynes VioletHynes merged commit 20d1660 into release/1.11.x Aug 24, 2022
@VioletHynes VioletHynes deleted the backport/violethynes/VAULT-7698/uniformly-present-beetle branch August 24, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants