Load SSCT Generation Counter Upon DR Promotion [OSS] #16956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Aug 31, 2022
changelog/16956.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| core: Load SSCT Token Generation counter from storage when upgrading a DR to a primary | |||
There was a problem hiding this comment.
This describes the change but isn't meaningful to most changelog readers. Can you instead describe the change from a user perspective?
ncabatoff
approved these changes
Aug 31, 2022
raskchanky
approved these changes
Aug 31, 2022
This was referenced Aug 31, 2022
|
The associated enterprise changes for this fix didn't merge alongside the OSS changes. The enterprise changes will be released in 1.10.10. The whole change was released in 1.11.4. |
|
Upon further review, it looks like the enterprise changes are tests. Those have merged into 1.10.x now on the enterprise side, so it's good that this is complete, but I think the functionality was fully released in 1.10.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a port of https://github.com/hashicorp/vault-enterprise/pull/3170/files.
Description (from ent PR):
This PR fixes the regression with SSCT.
The issue is that the SSCT Generation counter was not being loaded from storage, so when it was written to storage during DR promotion it would always be 1. The fix is to load the value from storage during DR promotion. DRs never use the generation counter, but on DR clusters the value in memory will always be 1 less than the value in storage. However, the moment the DR gets updated to a primary, the value from storage will be incremented and written back.
Will open the OSS port after this PR is approved, with a changelog in OSS.
The PR will need to be backported to 1.10.