Add new API to PKI to list revoked certificates #17779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A new API that will return the list of serial numbers of revoked certificates on the local cluster.
cipherboy
reviewed
Nov 3, 2022
|
|
||
| | Method | Path | | ||
| |:-------|:------------------| | ||
| | `LIST` | `/certs/revoked` | |
There was a problem hiding this comment.
Suggested change
| | `LIST` | `/certs/revoked` | | |
| | `LIST` | `/certs/revoked` | |
I'm sorry, it just annoys me :-D
There was a problem hiding this comment.
Oops yup will fix this, thanks for catching it!
| @@ -1216,3 +1216,12 @@ func (sc *storageContext) writeAutoTidyConfig(config *tidyConfig) error { | |||
|
|
|||
| return sc.Storage.Put(sc.Context, entry) | |||
| } | |||
|
|
|||
| func (sc *storageContext) listRevokedCerts() ([]string, error) { | |||
There was a problem hiding this comment.
Ah cool, we should use this elsewhere eventually :)
| requireSuccessNonNilResponse(t, resp, err, "error revoking cert 2") | ||
|
|
||
| // Test that we get back the expected serial numbers. | ||
| resp, err = CBList(b, s, "certs/revoked") |
There was a problem hiding this comment.
Wanna also make sure we see these serial numbers in the regular list too?
There was a problem hiding this comment.
By regular list are you referring to LIST /certs?
cipherboy
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new API that will return the list of serial numbers of revoked certificates on the local cluster.