Add default to allowed values for algorithm_signer

[bluestealth]

• Adds default to allowed values for algorithm_signer to ssh plugin API introduced in Expose ssh algorithm_signer in web interface (#10114) #10299

[hellobontempo]

Our design team got back to me and requested that this be a dropdown select instead!

in role-ssh.js could you add possibleValues to the attribute

@cipherboy - if you want to confirm I got these right?

  algorithmSigner: attr('string', {
    helpText: 'When supplied, this value specifies a signing algorithm for the key',
    possibleValues: ['', 'default', 'ssh-rsa', 'rsa-sha2-256', 'rsa-sha2-512']
    
  }),

[cipherboy]

@hellobontempo -- the last one should have a - rather than an = sign, but yes, LGTM :-)

[hellobontempo]

@hellobontempo -- the last one should have a - rather than an = sign, but yes, LGTM :-)

whoops - typo! thanks :)

[hellobontempo]

Thanks for the swift change!

Reviewing #14006 - since an empty string updates to default can we remove that from the array of possibleValues here? My apologies for the rigamarole, I noticed this while testing. It's slightly awkward UX to select nothing from the dropdown and then after saving have it magically change to "Signing Algorithm: default"

form

config

@cipherboy - not sure if you have an argument to keep it as a dropdown option? If so, then we can remove line 123 all together if the options are going to be the same as the backend as the dropdown complies automagically when
AllowedValues exist

[bluestealth]

@hellobontempo that actually makes a lot of sense, made that change.

[hellobontempo]

thank you!

[hellobontempo]

@cipherboy Do you know how to get the Vercel status check to run here?

[cipherboy]

@hellobontempo I don't think Vercel is holding this one up, I think completed-successfully is, but we might be able to get someone to admin merge it. But no, apparently I can no longer manage Vercel jobs... Uh-oh.

[hellobontempo]

@hellobontempo I don't think Vercel is holding this one up, I think completed-successfully is, but we might be able to get someone to admin merge it. But no, apparently I can no longer manage Vercel jobs... Uh-oh.

Oh, I didn't even see that one. Can someone in your channel admin merge? Or should I post elsewhere?