Log environment variable keys at startup #18125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliesterner
requested review from
ltcarbonell,
davidadeleon and
jasonodonnell
ltcarbonell
approved these changes
Nov 29, 2022
jasonodonnell
suggested changes
Nov 30, 2022
Co-authored-by: Jason O'Donnell <[email protected]>
Comment on lines
+1306
to
+1307
| splitEnvVars := strings.Split(v, "=") | ||
| envVarKeys = append(envVarKeys, splitEnvVars[0]) |
There was a problem hiding this comment.
This formatting looks wrong, can you run make fmt in the root directory and commit the changes (if any)?
There was a problem hiding this comment.
that's weird. It looks way more indented in GH than on my local.
jasonodonnell
approved these changes
Dec 2, 2022
Co-authored-by: Jason O'Donnell <[email protected]>
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Log environment variable keys at startup * run make fmt * change name * add changelog * fix changelog nubmer * fix title * add test * fix message * Update changelog/18125.txt Co-authored-by: Jason O'Donnell <[email protected]> * add trace test * remove check for >= debug, trace * Update changelog/18125.txt Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log only the keys to environment variables on startup.
Example: