Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenAPI request/response naming strategy #18321

Closed
wants to merge 32 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
45aee60
Improve OpenAPI request/response naming strategy
averche Dec 12, 2022
691e29b
default mappings
averche Dec 12, 2022
1fad3a1
change the mapped names
averche Dec 14, 2022
ed954bf
add operationImplied flag
averche Dec 14, 2022
a1058a5
Add a test
averche Dec 14, 2022
7a9b75d
changelog
averche Dec 14, 2022
59a692f
requestResponsePrefix -> defaultMountPath
averche Dec 14, 2022
7a39ca9
update -> write
averche Dec 14, 2022
3b90f9a
fix test
averche Dec 14, 2022
91a5134
undo test change
averche Dec 14, 2022
19d5ef0
move the map into openapi_path_mappings.go
averche Dec 19, 2022
2375e5e
Update table with prefix/operation/suffix struct
averche Dec 20, 2022
0d14048
Fix function and test
averche Dec 20, 2022
4d5ccb9
test
averche Dec 20, 2022
ac7fe27
mountPathWithPrefix
averche Dec 20, 2022
0be96b8
mountPathWithPrefix
averche Dec 20, 2022
a0a65bf
comment
averche Dec 20, 2022
8e34fda
Adjust certain path mappings
averche Dec 21, 2022
77684f5
undo script changes
averche Dec 21, 2022
dc6fb71
Merge branch 'main' into ui/openapi-request-response-names
averche Dec 21, 2022
dd5767c
spaces
averche Dec 21, 2022
1e6bfe2
don't need path lib
averche Dec 21, 2022
70ec341
dedup
averche Dec 21, 2022
5165291
change KVv1/KVv2 naming structure
averche Jan 2, 2023
f1b79a1
Merge branch 'main' into ui/openapi-request-response-names
averche Jan 3, 2023
d8d4413
Add back CreateOperationIDs
averche Jan 4, 2023
9ad60e9
comment
averche Jan 4, 2023
66a741b
rename constructOperationID and address PR feedback
averche Jan 5, 2023
9088087
fix tests
averche Jan 5, 2023
f1d7eff
add updateOperationOnly flag
averche Jan 5, 2023
27da1e3
fix test
averche Jan 5, 2023
98dae14
remove kv -> secret hack
averche Jan 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
averche committed Dec 20, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 4d5ccb97158c666f1a0dc5f9d2c49ff86b2576bb
2 changes: 1 addition & 1 deletion sdk/framework/openapi_test.go
Original file line number Diff line number Diff line change
@@ -688,7 +688,7 @@ func TestOpenAPI_constructRequestResponseIdentifier(t *testing.T) {
path: "unseal",
expected: "Unseal",
}, {
name: "mapped entry with operation and suffix",
name: "mapped entry with operation, prefix, and suffix",
operation: logical.UpdateOperation,
mount: "gcp",
path: "roleset/{name}/rotate",