Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12112: add openapi responses for /sys/internal endpoints #18542

Merged
merged 12 commits into from
Feb 24, 2023
Merged

VAULT-12112: add openapi responses for /sys/internal endpoints #18542

merged 12 commits into from
Feb 24, 2023

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Dec 23, 2022 •
edited
Loading

Path Operation response notes
/sys/internal/ui/feature-flags READ link added test
/sys/internal/ui/mounts READ link
/sys/internal/ui/mounts/{path} READ link
/sys/internal/ui/namespaces READ link no test exists
/sys/internal/ui/resultant-acl READ link test needs to wait until schema for /v1/auth/token/create is merged
/sys/internal/counters/requests READ link returns nothing, should be deprecated
/sys/internal/counters/tokens READ link
/sys/internal/counters/entities READ link

tests added

@dhuckins dhuckins added this to the 1.13.0-rc1 milestone Dec 23, 2022
@dhuckins dhuckins marked this pull request as ready for review December 23, 2022 17:50
@dhuckins dhuckins changed the title add openapi responses for /sys/internal endpoints VAULT-12112: add openapi responses for /sys/internal endpoints Jan 5, 2023
@averche averche modified the milestones: 1.13.0-rc1, 1.14 Feb 13, 2023
averche
averche approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

vault/logical_system_paths.go Show resolved Hide resolved
@dhuckins dhuckins merged commit 6080a01 into main Feb 24, 2023
@dhuckins dhuckins deleted the dh/response-structures-sys-1-internal branch February 24, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnPucel AnPucel AnPucel left review comments

@averche averche averche approved these changes

@lursu lursu Awaiting requested review from lursu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@dhuckins @AnPucel @averche