Backport of Correctly distinguish empty issuer names in PKI into release/1.12.x #18647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-fix-name-on-empty-but-provided-issuer-name/thoroughly-accepted-ladybird
branch
2 times, most recently
from
2ee56ae to
649c5fd
Compare
…ty-but-provided-issuer-name/thoroughly-accepted-ladybird
cipherboy
approved these changes
Jan 10, 2023
…ty-but-provided-issuer-name/thoroughly-accepted-ladybird
cipherboy
deleted the
backport/cipherboy-fix-name-on-empty-but-provided-issuer-name/thoroughly-accepted-ladybird
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18466 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
When using
client.Logical().JSONMergePatch(...)with an empty issuer name, patch incorrectly reports:In this case, both the error in getIssuerName(...) is incorrect and patch should allow setting an empty issuer name explicitly.
Signed-off-by: Alexander Scheel <[email protected]>Notably, while this also affects
vault write, the new error message should be clearer and users can simply elide theissuer_nameparameter (with empty value) and the the same behavior (clearing the name). However, forvault patchthere is no equivalent and thus they have to have this bug fix.Overview of commits