Backport of secrets/mysql: Add tls_server_name and tls_skip_verify parameters into release/1.12.x
#18804
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/mysql-tls-server-name/previously-daring-aardvark
branch
2 times, most recently
from
62e8aaa to
863f47f
Compare
jasonodonnell
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18799 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
The MySQL implementation supports TLS verification and auth, however, when testing against Cloud SQL it was very painful to verify the CA. This is because Cloud SQL does not add IP SANs to the certificate. The SANs available reference internal VM names which aren't easily obtainable as a user. I've added these parameters to make the engine more flexible. Although the connection url does support these, the MySQL driver stores a tls.Config and references it by name in the connection URL, so it makes sense to add these there.
Overview of commits