address various issues with the output-policy flag #19160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lursu
changed the title
averche
reviewed
Feb 14, 2023
api/output_policy.go
Outdated
| if d.params.Has(listKey) { | ||
| isList, err := strconv.ParseBool(d.params.Get(listKey)) | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
This error could probably be improved with some context. Alternatively you can simply check for strings.Lower(d.params.Get("list")) == "true" or something similar
digivava
reviewed
Feb 14, 2023
digivava
reviewed
Feb 14, 2023
Co-authored-by: Anton Averchenkov <[email protected]>
averche
reviewed
Feb 15, 2023
averche
approved these changes
Feb 16, 2023
digivava
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing various issues called out by this sustaining issue, some are not going to be fixed by this PR but rather in a longer term follow up initiative to change how we handle the policy building.
For now though we will address the following which were tested locally:
Update the error message when trying to generate a policy for kvV2 where
/data/is not properly contained in the path provided.Capture the list url param that is passed on list commands since a lists HTTP Verb is GET instead of LIST.
Since we have aggressive and decentralized path sanitization for all command requests, we needed to change the sudo path regex for paths with a trailing
/. The change is to make the trailing/optional since it is technically correct to have it but every command removes the users input before we could check the path.