Events API uses consistent error codes #19246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small tweaks for consistency:
EDIT: Superseded by events: WS protobuf messages should be binary #19232 which changed to returning the cloud events formatted version of the event. I kept the additional test coverage though.UseProtoNames
when serializing JSON fields to ensure we use underscores instead of proto3's default camel case to make us consistent with the rest of the Vault API.For illustration on the status codes: