Add Helios Design System Components #19278
Conversation
zofskeez
changed the title
| @@ -42,6 +42,8 @@ const appConfig = { | |||
| implementation: nodeSass, | |||
| sourceMap: false, | |||
| onlyIncluded: true, | |||
| precision: 4, | |||
There was a problem hiding this comment.
I suggest, if not done yet, to add also this:
minifyCSS: {
options: {
advanced: false,
},
},
see how it's done in Cloud UI for example: https://github.com/hashicorp/cloud-ui/blob/main/hcp/ember-cli-build.js#L214-L218
There was a problem hiding this comment.
Thanks for pointing this out @didoo. I'm not seeing any mention of this option in the broccoli-clean-css docs or the clean-css docs. Do you have any information on what that option does and/or why it's needed? It might be a good idea to add it to the Getting started for engineers section of the Helios docs as well.
There was a problem hiding this comment.
I'm not seeing any mention of this option in the broccoli-clean-css docs or the clean-css docs. Do you have any information on what that option does and/or why it's needed?
@zofskeez it's some arcane ember "magic" that we found was messing up the generation of CSS (essentially was super-optimizing the CSS, beyond what is normally done, by even changing the order of the CSS declarations which is a no-no in CSS, where order matters).
A couple of links for reference:
- https://github.com/hashicorp/cloud-ui/pull/3112
- Remove implicit CSS minification ember-cli/ember-cli#8457
- super mega thread: https://hashicorp.slack.com/archives/CPB8GS9QT/p1658220312956889
It might be a good idea to add it to the Getting started for engineers section of the Helios docs as well.
Good point, I'll open a PR immediately!
There was a problem hiding this comment.
There was a problem hiding this comment.
Great thanks for the additional context on this. It looks like it was a tough one to track down so I appreciate pointing it out and updating the docs!
* Add Helios Design System Components (#19278) * adds hds dependency * updates reset import path * sets minifyCSS advanced option to false * Remove node-sass (#19376) * removes node-sass and fixes sass compilation * fixes active tab li class * Sidebar Navigation Components (#19446) * links ember-shared-components addon and imports styles * adds sidebar frame and nav components * updates HcNav component name to HcAppFrame and adds sidebar UserMenu component * adds tests for sidebar components * fixes tests * updates user menu styling * fixes typos in nav cluster component * changes padding value in sidebar stylesheet to use variable * Replace and remove old nav components with new ones (#19447) * links ember-shared-components addon and imports styles * adds sidebar frame and nav components * updates activeCluster on auth service and adds activeSession prop for sidebar visibility * replaces old nav components with new ones in templates * fixes sidebar visibility issue and updates user menu label class * removes NavHeader usage * adds clients index route to redirect to dashboard * removes unused HcAppFrame footer block and reduces page header top margin * Nav component cleanup (#19681) * removes nav-header components * removes navbar styling * removes status-menu component and styles * removes cluster and auth info components * removes menu-sidebar component and styling * fixes tests * Console Panel Updates (#19741) * updates console panel styling * adds test for opening and closing the console panel * updates console panel background color to use hds token * adds right margin to console panel input * updates link-status banner styling * updates hc nav components to new API * Namespace Picker Updates (#19753) * updates namespace-picker * updates namespace picker menu styling * adds bottom margin to env banner * updates class order on namespace picker link * restores manage namespaces refresh icon * removes manage namespaces nav icon * removes home link component (#20027) * Auth and Error View Updates (#19749) * adds vault logo to auth page * updates top level error template * updates loading substate handling and moves policies link from access to cluster nav (#20033) * moves console panel to bottom of viewport (#20183) * HDS Sidebar Nav Components (#20197) * updates nav components to hds * upgrades project yarn version to 3.5 * fixes issues in app frame component * updates sidenav actions to use icon button component * Sidebar navigation acceptance tests (#20270) * adds sidebar navigation acceptance tests and fixes other test failures * console panel styling tweaks * bumps addon version * remove and ignore yarn install-state file * fixes auth service and console tests * moves classes from deleted files after bulma merge * fixes sass syntax errors blocking build * cleans up dart sass deprecation warnings * adds changelog entry * hides namespace picker when sidebar nav panel is minimized * style tweaks * fixes sidebar nav tests * bumps hds addon to latest version and removes style override * updates modify-passthrough-response helper * updates sidebar nav tests * mfa-setup test fix attempt * fixes cluster mfa setup test * remove deprecated yarn ignore-optional flag from makefile * removes another instance of yarn ignore-optional and updates ui readme * removes unsupported yarn verbose flag from ci-helper * hides nav headings when user does not have access to any sub links * removes unused optional deps and moves lint-staged to dev deps * updates has-permission helper and permissions service tests * fixes issue with console panel not filling container width
This PR brings in the Helios design system components in preparation for consuming the
hc-navaddon as well as wider design system adoption.