UI: fixes validation bug in pki role sign certificate form #19280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
changed the title
hellobontempo
commented
Feb 22, 2023
| name: string; | ||
| backend: string; |
There was a problem hiding this comment.
All of these existed in the base model so seemed reasonable to remove these duplicates?
hellobontempo
added a commit
that referenced
this pull request
Feb 22, 2023
* move validations to base certificate * add test
hellobontempo
added a commit
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validations were added to the generate certificate from a role form (#19035) we missed that two different models are passed to the same
PkiRoleGenerate.tscomponent (pki/certificate/signandpki/certificate/generate) and only one of them had the validations decorator.Initially, I moved validations to the base certificate model, but then opted to remove validations all together because requiring a common name depends on the role. The default is to require it, but this param can be changed (docs) and applies to both signing and generating a certificate. The error message returned by the API feels sufficient to guide the user: