Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x/net and x/crypto/ssh #19282

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Update x/net and x/crypto/ssh #19282

merged 2 commits into from
Feb 22, 2023

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Feb 22, 2023 •
edited
Loading

I'll make a patch release for api and sdk once this is merged.

@tomhjp tomhjp requested review from tvoran and cipherboy February 22, 2023 12:38
cipherboy
cipherboy reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind also bumping in the main vault/go.mod? Thanks!

@tomhjp tomhjp changed the title Update x/net and x/crypto/ssh in api and sdk Update x/net and x/crypto/ssh Feb 22, 2023
@tomhjp
Copy link
Contributor Author

tomhjp commented Feb 22, 2023

Do you mind also bumping in the main vault/go.mod? Thanks!

As it happens I was just doing this after seeing the failed builds. I thought it would all shake out in the minimum version selection algorithm, but seems like running go mod tidy after the api and sdk updates automatically pulled in updates to the root go module too.

cipherboy
cipherboy reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it happens I was just doing this after seeing the failed builds.

Ha, thanks!! I hadn't seen the failed builds yet. :D

@tomhjp tomhjp enabled auto-merge (squash) February 22, 2023 13:39
@tomhjp tomhjp merged commit 4df7c64 into main Feb 22, 2023
This was referenced Feb 22, 2023
Merged
Merged
Merged
@tomhjp tomhjp deleted the bump-x-deps branch February 22, 2023 13:55
@tomhjp tomhjp added dependencies Pull requests that update a dependency file backport/1.10.x labels Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

@cipherboy cipherboy cipherboy approved these changes

@tvoran tvoran Awaiting requested review from tvoran

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomhjp @cipherboy @ncabatoff