Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: remove Consul data plane warning from Consul Secrets Engine page into release/1.10.x #19301

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19300 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Consul 1.14.0 comes with a new model for deploying Consul without agents on K8s. Removing this warning since this is not relevant to Consul Secrets agent as the warning is only needed for the instance where Consul is used as backend storage to Vault.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/docs/vault-consul-dataplane/widely-wondrous-mantis branch from 69e215a to 4cec903 Compare February 22, 2023 22:45
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 22, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • david-yu
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@david-yu david-yu marked this pull request as ready for review February 22, 2023 23:47
@david-yu
Copy link

@ccapurso Ready to merge.

@ccapurso
Copy link
Contributor

Closing due to the CLA issue. I have opened up #19306 instead.

@ccapurso ccapurso closed this Feb 23, 2023
@ccapurso ccapurso deleted the backport/docs/vault-consul-dataplane/widely-wondrous-mantis branch February 23, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants