Refactor OCSP client to support better retries #19345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirror NSS's GET-vs-POST selection criteria, wherein GET is preferred over POST (as the former might be a response from a cached CDN entry, whereas the latter might hit a live responder). However, only accept it if it definitively says "Good" or "Revoked" -- trigger a POST request when an unknown or failure status is seen. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added
bug
stevendpclark
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror NSS's GET-vs-POST selection criteria, wherein GET is preferred over POST (as the former might be a response from a cached CDN entry, whereas the latter might hit a live responder). However, only accept it if it definitively says "Good" or "Revoked" -- trigger a POST request when an unknown or failure status is seen.
Because existing Vault PKI engines respond with a parse error, and not Method Not Allowed, this would probably be useful to backport to 1.13, which is the first release with OCSP support.