Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: Add display attributes for approle #19363

Merged
merged 45 commits into from
Apr 6, 2023
Merged

Conversation

averche
Copy link
Contributor

@averche averche commented Feb 24, 2023

Please see #19319 for more details on how this will affect the generated OpenAPI schema.


The following OperationID's will be generated for AppRole:

app-role-log-in
app-role-list-roles
app-role-read-role
app-role-write-role
app-role-delete-role
app-role-read-bind-secret-id
app-role-write-bind-secret-id
app-role-delete-bind-secret-id
app-role-read-bound-cidr-list
app-role-write-bound-cidr-list
app-role-delete-bound-cidr-list
app-role-write-custom-secret-id
app-role-read-local-secret-ids
app-role-read-period
app-role-write-period
app-role-delete-period
app-role-read-policies
app-role-write-policies
app-role-delete-policies
app-role-read-role-id
app-role-write-role-id
app-role-list-secret-ids
app-role-write-secret-id
app-role-destroy-secret-id-by-accessor
app-role-destroy-secret-id-by-accessor2
app-role-look-up-secret-id-by-accessor
app-role-read-secret-id-bound-cidrs
app-role-write-secret-id-bound-cidrs
app-role-delete-secret-id-bound-cidrs
app-role-read-secret-id-num-uses
app-role-write-secret-id-num-uses
app-role-delete-secret-id-num-uses
app-role-read-secret-id-ttl
app-role-write-secret-id-ttl
app-role-delete-secret-id-ttl
app-role-destroy-secret-id
app-role-destroy-secret-id2
app-role-look-up-secret-id
app-role-read-token-bound-cidrs
app-role-write-token-bound-cidrs
app-role-delete-token-bound-cidrs
app-role-read-token-max-ttl
app-role-write-token-max-ttl
app-role-delete-token-max-ttl
app-role-read-token-num-uses
app-role-write-token-num-uses
app-role-delete-token-num-uses
app-role-read-token-ttl
app-role-write-token-ttl
app-role-delete-token-ttl
app-role-tidy-secret-id

@averche averche added this to the 1.14 milestone Feb 24, 2023
Copy link
Collaborator

@lursu lursu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AnPucel AnPucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, do we need to update these display attrs for all endpoints to get a well-formatted OperationID?

@averche
Copy link
Contributor Author

averche commented Feb 24, 2023

Unfortunately, yes. Some names will be reasonable without updating them in display attributes but I'd rather do it consistently for all built-in plugins.

Base automatically changed from ui/openapi-naming-strategy to main April 4, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants