Fix for PKI.TestStandby_Operations test to work in ENT #19647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
Mar 20, 2023
stevendpclark
commented
- Remove wait call to testhelpers.WaitForActiveNodeAndStandbys and leverage testhelpers.WaitForStandbyNode instead.
- Remove wait call to testhelpers.WaitForActiveNodeAndStandbys and leverage testhelpers.WaitForStandbyNode instead.
mpalmi
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
I'm okay with this fix, but curious if @ncabatoff has any insight into a better one. Approving to unblock this, as it's currently failing in the OSS->ENT merge initiated earlier today.
mpalmi
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.