Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Test business logic for oidc callback params into release/1.11.x #19780

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19727 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR moves the logic that happens in beforeModel for the oidc callback route into an easily-testable method.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/oidc-callback-fn-tests/violently-working-antelope branch from d184815 to bb3c20e Compare March 27, 2023 20:05
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/oidc-callback-fn-tests/violently-working-antelope branch from bb3c20e to d184815 Compare March 27, 2023 20:06
@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 6, 2023
@schavis schavis added vault-update Used by SPE team to filter out PRs not related to content failed-backport labels Feb 22, 2024
@peteski22 peteski22 closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed vault-update Used by SPE team to filter out PRs not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants