Support namespaces in test helpers #20048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
approved these changes
Apr 11, 2023
cipherboy
force-pushed
the
cipherboy-support-namespaces-testhelpers
branch
from
5a60242 to
cf8d74a
Compare
Sometimes the tests will modify the client to set a namespace; this results in testhelpers sometimes trying to access sys/ endpoints with a namespace, which usually don't work well. Detect an unset namespaces, if present, before executing, and restore afterwards so as not to affect the tests. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-support-namespaces-testhelpers
branch
from
cf8d74a to
4af9ca0
Compare
stevendpclark
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the tests will modify the client to set a namespace; this results in
testhelperssometimes trying to accesssys/endpoints with a namespace, which usually don't work well.Detect an unset namespaces, if present, before executing, and restore afterwards so as not to affect the tests.