Structure of ACME Tidy #20494
Merged
Structure of ACME Tidy #20494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
reviewed
May 3, 2023
cipherboy
reviewed
May 3, 2023
cipherboy
reviewed
May 5, 2023
cipherboy
reviewed
May 5, 2023
builtin/logical/pki/path_tidy.go
Outdated
| TidyAcme: false, | ||
| SafetyBuffer: 72 * time.Hour, | ||
| IssuerSafetyBuffer: 365 * 24 * time.Hour, | ||
| AcmeAccountSafetyBuffer: 48 * time.Hour, |
There was a problem hiding this comment.
Given that certbot doesn't gracefully handle account removal, I'd maybe make this 30 days perhaps by default.
There was a problem hiding this comment.
Gotcha. I've done that. Did you want this to apply to time after order/cert expiry as well, if certbot doesn't handle that well?
cipherboy
reviewed
May 5, 2023
builtin/logical/pki/path_tidy.go
Outdated
| } | ||
|
|
||
| for _, thumbprint := range list { | ||
| b.tidyAcmeAccountByThumbprint(b.acmeState, acmeCtx, thumbprint, config.SafetyBuffer, config.AcmeAccountSafetyBuffer) |
There was a problem hiding this comment.
It looks like this returns an error, should it be handled?
There was a problem hiding this comment.
I was thinking that an error on any particular account shouldn't stop the tidy, but I probably should log it, so thank you. Logging added.
cipherboy
approved these changes
May 5, 2023
kitography
deleted the
VAULT-13351-acme-add-purge-expired-orders-and-challenges-to-tidy-auto-tidy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Track Creation Date of Account
-- Configure Account Safety Buffer on Tidy (Read, Write)
-- Configure Account Safety Buffer on Auto-Tidy
-- Revoke after safety-period (Date stored to ensure this)
-- Delete safety-period after revocation
More Testing to Come