Backport of Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false into release/1.13.x #20679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-fix-bug-setting-both-fields-false/thoroughly-capable-gazelle
branch
2 times, most recently
from
0d23907 to
6b99ca7
Compare
|
|
Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false (#20664) * Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false The logic around the check to set both to false was wrong, and should be validated independently. Additionally, these fields should only exist on auto-tidy and not on the manual tidy endpoint. Signed-off-by: Alexander Scheel <[email protected]> * Update builtin/logical/pki/path_tidy.go Co-authored-by: claire bontempo <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]> Co-authored-by: claire bontempo <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
backport/cipherboy-fix-bug-setting-both-fields-false/thoroughly-capable-gazelle
branch
from
fa6ca7b to
ec26e22
Compare
cipherboy
approved these changes
May 19, 2023
|
See note here: #18186; closing. If we later revisit that PR to backport it to 1.13 and 1.12, we'll need to finish these backports as well. |
auto-merge was automatically disabled
May 22, 2023 14:40
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20664 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
🚨
The person who merged in the original PR is:
@cipherboy
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
The logic around the check to set both to false was wrong, and should be validated independently.
Additionally, these fields should only exist on auto-tidy and not on the manual tidy endpoint.
Overview of commits