Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Improve consul secrets plugin error for failed bootstrap into release/1.14.x #20893

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20891 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


When returning a logical error, we need to include all of the information the user should see within the response. As seen in #18705, there is currently no indication of why the bootstrapping failed when it does.

Before:

$ vault write consul/config/access \
    address="https://127.0.0.1:8500"
Error writing data to consul/config/access: Error making API request.

URL: PUT http://127.0.0.1:8200/v1/consul/config/access
Code: 400. Errors:

* Token not provided and failed to bootstrap ACLs

After:

$ vault write consul/config/access \
    address="https://127.0.0.1:8500"
Error writing data to consul/config/access: Error making API request.

URL: PUT http://127.0.0.1:8200/v1/consul/config/access
Code: 400. Errors:

* Token not provided and failed to bootstrap ACLs: Put "https://127.0.0.1:8500/v1/acl/bootstrap": http: server gave HTTP response to HTTPS client

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core requested a review from a team May 31, 2023 15:31
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/18705-consul-bootstrap-error/frankly-helped-bulldog branch 2 times, most recently from 3288fd4 to 2777f66 Compare May 31, 2023 15:31
@tomhjp tomhjp added this to the 1.14 milestone May 31, 2023
@tomhjp tomhjp enabled auto-merge (squash) May 31, 2023 15:32
@tomhjp tomhjp merged commit e41e43b into release/1.14.x May 31, 2023
@tomhjp tomhjp deleted the backport/18705-consul-bootstrap-error/frankly-helped-bulldog branch May 31, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants