Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix incorrect OpenAPI operation ID into release/1.14.x #21551

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #21543 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


The operation ID for GET auth/token/lookup has been overridden in
a way which implies it can only perform lookup-self operations.

This isn't actually the case, as shown:

  1. Here is my current token:
$ vault read -field=display_name auth/token/lookup
userpass-admin
  1. I create a second token, with a different display name to distinguish
    it:
$ othertoken=$(vault token create -field=token -display-name=testing123)
  1. I use this operation, still authenticated with the first token, to
    lookup the second token, showing it is not actually a lookup-self operation:
$ vault read -field=display_name auth/token/lookup token=$othertoken
token-testing123

I have set the new operation ID suffix to "2" adhering to current
conventions in vault-client-go and vault-client-dotnet for secondary
versions of APIs which should be excluded from the generated library
code.

I have confirmed this doesn't give rise to any new clashes between operation IDs.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/fix-incorrect-openapi-operation-id/implicitly-novel-doberman branch 2 times, most recently from 30c10da to 3fedad8 Compare July 4, 2023 00:09
@averche averche enabled auto-merge (squash) July 4, 2023 00:10
@averche averche merged commit 5977c50 into release/1.14.x Jul 4, 2023
@averche averche deleted the backport/fix-incorrect-openapi-operation-id/implicitly-novel-doberman branch July 4, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants