Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Fix enterprise failure of TestCRLIssuerRemoval into release/1.15.x #23044

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Backport of Fix enterprise failure of TestCRLIssuerRemoval into release/1.15.x #23044

merged 1 commit into from
Sep 13, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23038 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.

This fixes the enterprise failure of the test introduced through #23007

 === FAIL: builtin/logical/pki TestCRLIssuerRemoval (0.00s)
    crl_test.go:1456:
        	Error Trace:	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/builtin/logical/pki/crl_test.go:1456
        	Error:      	Received unexpected error:
        	            	Global, cross-cluster revocation queue cannot be enabled when auto rebuilding is disabled as the local cluster may not have the certificate entry!
        	Test:       	TestCRLIssuerRemoval
        	Messages:   	failed enabling unified CRLs on enterprise
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/fix-test-crl-issuer-removal/widely-evolved-krill branch 2 times, most recently from 8f76724 to 91255d6 Compare September 13, 2023 12:22
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 13, 2023
@cipherboy cipherboy enabled auto-merge (squash) September 13, 2023 12:27
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@cipherboy cipherboy merged commit ae94024 into release/1.15.x Sep 13, 2023
@cipherboy cipherboy deleted the backport/stevendpclark/fix-test-crl-issuer-removal/widely-evolved-krill branch September 13, 2023 12:38
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@stevendpclark stevendpclark Awaiting requested review from stevendpclark

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-secure-vault-core @cipherboy @stevendpclark