Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix enterprise failure of TestCRLIssuerRemoval into release/1.14.x #23045

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23038 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


This fixes the enterprise failure of the test introduced through #23007

 === FAIL: builtin/logical/pki TestCRLIssuerRemoval (0.00s)
    crl_test.go:1456:
        	Error Trace:	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/builtin/logical/pki/crl_test.go:1456
        	Error:      	Received unexpected error:
        	            	Global, cross-cluster revocation queue cannot be enabled when auto rebuilding is disabled as the local cluster may not have the certificate entry!
        	Test:       	TestCRLIssuerRemoval
        	Messages:   	failed enabling unified CRLs on enterprise


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/fix-test-crl-issuer-removal/greatly-crucial-mutt branch from c308568 to 7ea2e6b Compare September 13, 2023 12:22
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/fix-test-crl-issuer-removal/greatly-crucial-mutt branch from 11227f4 to 59e7893 Compare September 13, 2023 12:22
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 13, 2023
@cipherboy cipherboy enabled auto-merge (squash) September 13, 2023 12:27
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@cipherboy cipherboy merged commit 296ec71 into release/1.14.x Sep 13, 2023
@cipherboy cipherboy deleted the backport/stevendpclark/fix-test-crl-issuer-removal/greatly-crucial-mutt branch September 13, 2023 12:39
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

cipherboy pushed a commit that referenced this pull request Sep 13, 2023
cipherboy pushed a commit that referenced this pull request Sep 13, 2023
cipherboy added a commit that referenced this pull request Sep 13, 2023
…elease/1.12.x (#23028)

* backport of commit e2ff1f1 (#23030)

Co-authored-by: Alexander Scheel <[email protected]>

* backport of commit 293e8b8 (#23045)

Co-authored-by: Steven Clark <[email protected]>

* Remove unified CRLs references from v1.12.x

Signed-off-by: Alexander Scheel <[email protected]>

---------

Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: Alexander Scheel <[email protected]>
Co-authored-by: Steven Clark <[email protected]>
cipherboy added a commit that referenced this pull request Sep 13, 2023
…elease/1.13.x (#23029)

* backport of commit e2ff1f1 (#23030)

Co-authored-by: Alexander Scheel <[email protected]>

* backport of commit 293e8b8 (#23045)

Co-authored-by: Steven Clark <[email protected]>

* Fix call of crlBuilder.rebuild

Signed-off-by: Alexander Scheel <[email protected]>

---------

Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: Alexander Scheel <[email protected]>
Co-authored-by: Steven Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants