Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: [VAULT-17461] add mount configuration as toggle for pki #23166

Merged
merged 7 commits into from
Sep 19, 2023
Merged

UI: [VAULT-17461] add mount configuration as toggle for pki #23166

merged 7 commits into from
Sep 19, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Sep 19, 2023 •
edited
Loading

Description

  • Update the mount configuration details to look like the new configuration details
Screenshot 2023-09-19 at 10 16 56 AM Screenshot 2023-09-19 at 10 17 04 AM Screenshot 2023-09-19 at 10 17 18 AM Screenshot 2023-09-19 at 10 17 30 AM

@kiannaquach kiannaquach added the ui label Sep 19, 2023
@kiannaquach kiannaquach added this to the 1.15.0 milestone Sep 19, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 19, 2023
@kiannaquach kiannaquach changed the title UI: add mount configuration as toggle for pki UI: [VAULT-17461] add mount configuration as toggle for pki Sep 19, 2023
@kiannaquach kiannaquach modified the milestones: 1.15.0, 1.13.8 Sep 19, 2023
@kiannaquach kiannaquach modified the milestones: 1.13.8, 1.15.0 Sep 19, 2023
@kiannaquach kiannaquach marked this pull request as ready for review September 19, 2023 18:29
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

kiannaquach
kiannaquach commented Sep 19, 2023
View reviewed changes
ui/tests/integration/components/pki/page/pki-configuration-details-test.js
{ owner: this.engine }
);
assert.dom(SELECTORS.rowValue('Cross-cluster revocation')).doesNotExist();
assert.dom(SELECTORS.rowValue('Unified CRL')).doesNotExist();
assert.dom(SELECTORS.rowValue('Unified CRL on existing paths')).doesNotExist();
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these test since the mount config now lives in the route template. There are also component tests for the SecretsEngineMountConfig component!

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@kiannaquach
Copy link
Contributor Author

kiannaquach commented Sep 19, 2023 •
edited
Loading

I'm only backporting this to 1.15 since the SecretsEngineMountConfig component was created in 1.15 and we're using the SecretsEngineMountConfig to show the mount config toggle

hellobontempo
hellobontempo reviewed Sep 19, 2023
View reviewed changes
ui/lib/pki/addon/templates/configuration/index.hbs Outdated
@cluster={{this.model.cluster}}
@urls={{this.model.urls}}
@crl={{this.model.crl}}
@mountConfig={{this.model.mountConfig}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this arg?

hellobontempo
hellobontempo approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling! - just an arg to cleanup

@kiannaquach kiannaquach enabled auto-merge (squash) September 19, 2023 22:39
@kiannaquach kiannaquach merged commit 6915edf into main Sep 19, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-17461/pki-config branch September 19, 2023 22:58
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kiannaquach @hellobontempo