Backport of Remove SA Credentials from DB Connection Details on Read into release/1.15.x #23257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/cloudsql-iam-credentials-read/amazingly-smooth-elephant
branch
from
4e439e0 to
7b77825
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/cloudsql-iam-credentials-read/amazingly-smooth-elephant
branch
from
035a8ac to
378cf4a
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
vinay-gopalan
approved these changes
Sep 22, 2023
|
Build Results: |
vinay-gopalan
deleted the
backport/cloudsql-iam-credentials-read/amazingly-smooth-elephant
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23256 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
Removes the
service_account_jsonparameter when reading DB connection details from Vault, similar to what we are doing forpasswordandprivate_key. For the DBs that don't have this parameter, this will be a no-op.Overview of commits