KV Download Value Stringify Toggle #23747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hashishaw
approved these changes
Oct 19, 2023
| as |F| | ||
| > | ||
| <F.Label>Stringify secret value</F.Label> | ||
| <F.HelperText>Preserve formatting for JSON values.</F.HelperText> |
There was a problem hiding this comment.
Minor nit, but the language here is unclear whether the current value will preserve formatting, or checking this option will preserve formatting. Maybe update to:
Suggested change
| <F.HelperText>Preserve formatting for JSON values.</F.HelperText> | |
| <F.HelperText>Selecting this option preserves formatting for JSON values.</F.HelperText> |
There was a problem hiding this comment.
I had something similar originally and this is the update I got from design. 🤷♂️
zofskeez
added a commit
that referenced
this pull request
Oct 20, 2023
* adds stringify toggle to masked-input download modal * updates stringify toggle copy and adds a test * adds changelog entry
zofskeez
added a commit
that referenced
this pull request
Oct 20, 2023
* adds stringify toggle to masked-input download modal * updates stringify toggle copy and adds a test * adds changelog entry
zofskeez
added a commit
that referenced
this pull request
Oct 20, 2023
* KV Download Value Stringify Toggle (#23747) * adds stringify toggle to masked-input download modal * updates stringify toggle copy and adds a test * adds changelog entry * adds modal wormhole to test
zofskeez
added a commit
that referenced
this pull request
Oct 20, 2023
* KV Download Value Stringify Toggle (#23747) * adds stringify toggle to masked-input download modal * updates stringify toggle copy and adds a test * adds changelog entry * removes extra test from backport for masked input * adds modal wormhole to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle to the KV secrets engine value download modal to optionally stringify the value. Previously the default behavior was to stringify which was adding escape characters for things like new lines that some users did not want. This will give control over how the value is represented in the downloaded file.
Closes #22279