Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency packages for sdk package #23913

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

dombalaz
Copy link
Contributor

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 31, 2023

CLA assistant check
All committers have signed the CLA.

@dombalaz dombalaz force-pushed the sdk-dependency-upgrade branch from 7809b83 to a900abd Compare October 31, 2023 09:47
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating these. I have gone ahead and updated the branch with main. I will merge once all the checks pass.

@@ -7,7 +7,7 @@ require (
github.com/armon/go-metrics v0.4.1
github.com/armon/go-radix v1.0.0
github.com/cenkalti/backoff/v3 v3.2.2
github.com/docker/docker v24.0.5+incompatible
github.com/docker/docker v24.0.7+incompatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI setup is failing due to a missing go.sum entry for this dependency. You can resolve with the following:

	github.com/docker/[email protected]+incompatible: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/docker/docker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason go mod download github.com/docker/docker did nothing for me. So I performed global update:

go mod download
go mod tidy

@ccapurso ccapurso merged commit b148f24 into hashicorp:main Nov 6, 2023
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants