[VAULT-21623] Close rate-limit client purge goroutines when sealing #24108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
davidadeleon
added
backport/1.13.x
and removed
hashicorp-contributed-pr
|
Build Results: |
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
davidadeleon
deleted the
davidadeleon/fix-rate-limit-quota-goroutine-leak
branch
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a goroutine leak when using rate-limit quotas. When using rate-limit quotas, a goroutine is started per quota to check at a set interval whether or not we can remove a client from being blocked. When Vault would undergo a state-change that required sealing, Vault was not closing these purge goroutines. When unsealing Vault would re-initialize the rate-limit quotas starting a new set of goroutines, leaking the old ones.