Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command: token capabilities using accessor #24479

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Command: token capabilities using accessor #24479

merged 3 commits into from
Dec 13, 2023

Conversation

mattias-fjellstrom
Copy link
Contributor

Fixes #24478

marcboudreau
marcboudreau suggested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@marcboudreau marcboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to ask that the Usage for the capabilities command be updated to include the -accessor case, but the existing pattern didn't make much sense, so I've suggested a wholesale change of the entire description.

command/token_capabilities.go Show resolved Hide resolved
command/token_capabilities.go Show resolved Hide resolved
command/token_capabilities.go Outdated Show resolved Hide resolved
command/token_capabilities.go Outdated Show resolved Hide resolved
command/token_capabilities.go Outdated Show resolved Hide resolved
marcboudreau
marcboudreau approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@marcboudreau marcboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution, I'll get this merged once all of the Github status checks have passed.

@marcboudreau marcboudreau merged commit e4ffe89 into hashicorp:main Dec 13, 2023
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcboudreau marcboudreau marcboudreau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List token capabilities using token accessor with the CLI
2 participants
@mattias-fjellstrom @marcboudreau