Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dashboard's QA card to search for nested KVv2 secrets #25001

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Jan 23, 2024

In the Secret Sync feature work a new component was added to solve the same issue of being unable to search within directories using the Search Select component. I added this new component to the dashboard.

Fixes Issue #23979.

Screen.Recording.2024-01-23.at.10.03.27.AM.mov

Note: this cannot be backported because the new component only exists as of 1.16.0

  • Locally Enterprise tests pass

@Monkeychip Monkeychip added ui bug Used to indicate a potential bug labels Jan 23, 2024
@Monkeychip Monkeychip added this to the 1.16.0-rc1 milestone Jan 23, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 23, 2024
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tackling!

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for swapping this out!

@Monkeychip Monkeychip merged commit 00157f0 into main Jan 23, 2024
72 checks passed
@Monkeychip Monkeychip deleted the ui/VAULT-22433/allow-nested-secret-dashboard branch January 23, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants