UI: Hds::Dropdown replace PopupMenu #25321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiannaquach
reviewed
Feb 9, 2024
ui/app/lib/attach-capabilities.js
Outdated
| @@ -34,7 +34,7 @@ import { isArray } from '@ember/array'; | |||
| export default function attachCapabilities(modelClass, capabilities) { | |||
| const capabilityKeys = Object.keys(capabilities); | |||
| const newRelationships = capabilityKeys.reduce((ret, key) => { | |||
| ret[key] = belongsTo('capabilities', { async: false, inverse: null }); | |||
| ret[key] = belongsTo('capabilities', { async: true, inverse: null }); | |||
There was a problem hiding this comment.
just out of curiosity why was it changed to async: true?
There was a problem hiding this comment.
Having it false was causing an error, I can't tell you much more than that!
There was a problem hiding this comment.
Specifically it caused this test to fail: auth-config-form options: it submits data correctly
There was a problem hiding this comment.
Just looked more into this and I think by updating the test we can leave this as async: false. I'll test the options locally as well to make sure they submit properly
This reverts commit 49eca9c.
Co-authored-by: Kianna <[email protected]>
kiannaquach
reviewed
Feb 9, 2024
| @hasChevron={{false}} | ||
| data-test-popup-menu-trigger | ||
| /> | ||
| <dd.CopyItem @text={{meta.public_key}} @copyItemTitle="Copy Public Key" /> |
There was a problem hiding this comment.
do we still want a flash message here?
There was a problem hiding this comment.
No, the copyItem component handles a successs icon
kiannaquach
approved these changes
Feb 9, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Feb 12, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates most of the instances of PopupMenu to the HDS Dropdown component.
The PopupMenu in
access/methods.hbsremains because removing it caused seemingly unrelated errors in tests. We will address that separately in its own PR, as it might require other refactors unrelated to simply replacing PopupMenu.