Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Request Limiter to enterprise #25615

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Move Request Limiter to enterprise #25615

merged 9 commits into from
Feb 27, 2024

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Feb 23, 2024

This is the subset of CE changes for https://github.com/hashicorp/vault-enterprise/pull/5479

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 23, 2024
@mpalmi mpalmi requested review from briankassouf, jasonodonnell and a team February 23, 2024 20:35
@mpalmi mpalmi added this to the 1.16.0 milestone Feb 23, 2024
@mpalmi mpalmi requested review from raskchanky and banks February 23, 2024 20:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

banks
banks approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. One query about an ENT-only file that seems to be still left in here but approving to unblock as it's not a show stopper. If that is something that's more complicated than just deleting it here, we can presumably do that later.

ccapurso
ccapurso approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mpalmi mpalmi force-pushed the ce/ent-request-limiter branch 2 times, most recently from ab84efa to 44a6ade Compare February 27, 2024 21:05
@mpalmi mpalmi merged commit b54ac98 into main Feb 27, 2024
99 of 133 checks passed
@mpalmi mpalmi deleted the ce/ent-request-limiter branch February 27, 2024 21:24
Merged
mpalmi added a commit that referenced this pull request Feb 27, 2024
@mpalmi
backport of commit b54ac98 (#25615)
7c29e60
mpalmi added a commit that referenced this pull request Feb 27, 2024
@hc-github-team-secure-vault-core @mpalmi
backport of commit b54ac98 (#25615) (#25680)
c04a33d 
Co-authored-by: Mike Palmiotto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

@ccapurso ccapurso ccapurso approved these changes

@briankassouf briankassouf Awaiting requested review from briankassouf

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

@raskchanky raskchanky Awaiting requested review from raskchanky

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mpalmi @banks @ccapurso