Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember upgrade prep: deprecate ember-data:no-a-with-array-like #25674

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Ember upgrade prep: deprecate ember-data:no-a-with-array-like #25674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84e721b
remove @filterBy
Monkeychip Feb 27, 2024
6e3034b
remove filterBy in old classic
Monkeychip Feb 28, 2024
d88afe5
Merge branch 'main' into ui/VAULT-24448/deprecate-a-usage
Monkeychip Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ui/app/controllers/vault/cluster/secrets/backends.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,20 @@ import Controller from '@ember/controller';
import { service } from '@ember/service';
import { action } from '@ember/object';
import { tracked } from '@glimmer/tracking';
import { filterBy } from '@ember/object/computed';
import { dropTask } from 'ember-concurrency';

export default class VaultClusterSecretsBackendController extends Controller {
@service flashMessages;
@filterBy('model', 'shouldIncludeInList') displayableBackends;

@tracked secretEngineOptions = [];
@tracked selectedEngineType = null;
@tracked selectedEngineName = null;
@tracked engineToDisable = null;

get displayableBackends() {
return this.model.filter((backend) => backend.shouldIncludeInList);
}

get sortedDisplayableBackends() {
// show supported secret engines first and then organize those by id.
const sortedBackends = this.displayableBackends.sort(
Expand Down
6 changes: 3 additions & 3 deletions ui/app/services/console.js
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried glimmerizing this service and it borked a bunch of stuff. There is talk of eventually replacing the console component with HDS so I'm going to refrain from going down that 🐇 hole.

Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

// Low level service that allows users to input paths to make requests to vault
// this service provides the UI synecdote to the cli commands read, write, delete, and list
import { filterBy } from '@ember/object/computed';

import Service from '@ember/service';

import { getOwner } from '@ember/application';
Expand All @@ -28,7 +26,9 @@ export default Service.extend({
adapter() {
return getOwner(this).lookup('adapter:console');
},
commandHistory: filterBy('log', 'type', 'command'),
get commandHistory() {
return this.log.filter((log) => log.type === 'command');
},
log: computed(function () {
return [];
}),
Expand Down
Loading