VAULT-24798: audit - improve error messages #26312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
core/audit
pr/no-changelog
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
peteski22
changed the title
peteski22
commented
Apr 9, 2024
sdk/go.sum
Outdated
There was a problem hiding this comment.
go mod tidy not sure why this got fiddled with though.
peteski22
commented
Apr 10, 2024
| @@ -36,34 +35,92 @@ type timeProvider interface { | |||
| formattedTime() string | |||
| } | |||
|
|
|||
| // FormatterConfig is used to provide basic configuration to a formatter. | |||
There was a problem hiding this comment.
FormatterConfig is moved from audit/types.go
peteski22
commented
Apr 10, 2024
| type EntryFormatter struct { | ||
| config FormatterConfig | ||
| salter Salter | ||
| logger hclog.Logger | ||
| name string | ||
| } | ||
|
|
||
| // NewFormatterConfig should be used to create a FormatterConfig. |
There was a problem hiding this comment.
NewFormatterConfig is moved up from lower down in the file.
ccapurso
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
opwhich was formerly part of all error messages in the audit sub-system.The idea is to make the errors we show to the user expose less of the guts of Vault (no mention of
file.Factoryetc.).It defines some typed errors which are used with wrapping to try and give us an idea of what was happening (
audit/errors.go), including if we want to return a more generic error to the caller (for the case of internal errors).Some receipts for the changes:
ENT PR: https://github.com/hashicorp/vault-enterprise/pull/5688