Updated consul-template version #26863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
I think it's necessary, since it affects the way Agent works, and some customers may be on the lookout for the bug fix in a Vault version. It's unlikely that Vault customers are looking at consul-template release notes, and they may not be aware that consul template powers Agent's template engine. We might want to backport this to 1.16, too (since LTS)! |
|
CI Results: |
|
Build Results: |
VioletHynes
approved these changes
May 7, 2024
Co-authored-by: Violet Hynes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought about it, and didn't add a changelog because technically the change was in consul-template, not in Vault? There's a changelog there to reflect that.
If you think it's necessary, I can add a changelog here as well.